Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some clarifications on wireless adapter docs #9

Closed
corwinkuiper opened this issue May 14, 2023 · 3 comments
Closed

Some clarifications on wireless adapter docs #9

corwinkuiper opened this issue May 14, 2023 · 3 comments

Comments

@corwinkuiper
Copy link

I'm just going through your improvements to the docs in detail in order to improve mine (yes, it has been a long while since you improved them!).

  1. Regarding IsConnectAttempt, it responds with a list of the connected adapters. My question is whether the 2 IDs fit in one value (due to IDs being 16 bits) or if each ID gets its own value.
  2. Regarding ReceiveData. So I don't think I had good evidence of the concatenation, I think I incorrectly extrapolated the limited data I had. I guess you confirmed this behaviour with more adapters than I have (I've got 2 adapters).
    • The header point seems strange to me. Given the format of the header is designed to make sure the headers from the clients don't overlap, my expectation would be for the headers to be ORed together.

If you have any logic captures from more than 2 adapters, I would love to see them.

@afska
Copy link
Owner

afska commented May 14, 2023

Hey Corwin,

  1. Each ID gets its own value (if I recall correctly, the most significant byte is zero on each ID). I've used this behavior on the library here to calculate the player count based on the response size.
  2. In all my tests the data was concatenated, and the first value in ReceiveData's response was a different header (the one I described is the header that SendData expects). I didn't spend too much time analyzing the form of ReceiveData's header. I imagine it's a bitfield indicating the packet size that was concatenated for each player.

I can make captures of a console connecting with other 3 LinkWireless_demo instances. Would that be helpful?
I don't have enough cartridges to perform the same test with commercial games.

@corwinkuiper
Copy link
Author

  1. Thanks for the clarification.
  2. Ah, it's a different header.

If it's not too much trouble to get that capture it would be much appreciated. I think I'll buy some more wireless adapters anyway.

@afska
Copy link
Owner

afska commented May 15, 2023

wireless-adapter-3player-traces.zip

Here are captures of two different 3-player sessions. One was recorded as the host, the other one as a client.

@afska afska closed this as completed in bef854d May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants