Automatically close a Dropdown when user clicks outside

[dgdavid]

After #545 be merged in master branch, the page options will be shown by using a PatternFly Dropdown placed close to the hamburger menu icon to open/close the sidebar.

The user can click on the arrow down icon to open the menu holding the options related to the current page. But this dropdown will be closed only when

• the user closes it by clicking in the arrow again
• the use clicks on any of the available options

Ideally, it should be closed automatically when clicking outside the dropdown itself too (right after losing the focus). At this time there is no prop (or I overlooked it) to tell the component to do so. But, looking at the source code it looks to me that current PatternFly Dropdown is/will be deprecated in favor of another that has a onOpenChange prop that might help to achieve the mentioned behavior. Have to check/test it better.

patternfly/patternfly-react@d43cf24

In any case, we should evaluate a way to automatically close that menu, although it is more a nice to have than a requirement for me.

[Anandpandey0]

I can do this . Please assign it to me.

[dgdavid]

I can do this .

That would be great, thanks a lot! Just in case it can help, we were thinking of having a look at the availability of the new PatternFly Dropdown component first.

Please assign it to me.

Done!

[dgdavid]

Please, bear in mind that you have to work on top of the issues branch at this moment or... just wait a bit until @joseivanlopez merge it to master. Needless to say that you can ask us for help here or in the #yast IRC channel at Libera.Chat network

[joseivanlopez]

Yes, you can create a PR through issues feature branch. Thanks!

[dgdavid]

@Anandpandey0,

Just in case you still interested on this issue, please be aware that issues branch was already merged into master. So you can start/continue working from there.

[dgdavid]

@Anandpandey0 just out of curiosity, are you finally playing with this one?

[balsa-asanovic]

Hey there,

Can I take this over if @Anandpandey0 is no longer interested?

[imobachgs]

To be honest, I do not know whether @Anandpandey0 is still interested. I would wait 1 or 2 weeks more and, if there is no response, I would reassign the issue to you, @balsa-asanovic.

[balsa-asanovic]

Sure, let's do that

[imobachgs]

OK, as @Anandpandey0 is not responding, I guess we can reassign this issue to @balsa-asanovic. Please, let us know whether you are still interested.

Thanks!

[balsa-asanovic]

Hey @imobachgs, yeah definitely, assign away 😄

[balsa-asanovic]

Hey @dgdavid @imobachgs ,

I wasn't sure should I tag some for pull request review, so here it is 😄

I've addressed this issue in PR #671

[imobachgs]

Hey @dgdavid @imobachgs ,

I wasn't sure should I tag some for pull request review, so here it is smile

We usually keep an eye on the projects' pull request list, but feel free to assign the review to any of us just to be sure 😉

I've addressed this issue in PR #671

Thanks!

[balsa-asanovic]

We usually keep an eye on the projects' pull request list, but feel free to assign the review to any of us just to be sure 😉

Great, thanks for the info!