Add some benchmarking tools #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
force-pushed
the
io-benchmarking
branch
from
c79a89e
to
3c179a6
Compare
Necessary to make it easier to use the TimedWriter decorator with it.
- Making use of some rather general utilities that simply wrap calls to member functions inbetween two calls to clock::now() to calculate the duration of the call.
tmadlener
force-pushed
the
io-benchmarking
branch
from
3c179a6
to
959817a
Compare
gaede
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
TimedReaderandTimedWriterdecorators that allow to wrap (interface conforming) readers and writers and record the times different operations take. The times are recorded on two levels: setup times, like constructing a reader or "one-time" calls and per event times, for things that happen each event (e.g.writeEventorreadCollection). Additionally theBenchmarkRecorderin principle also allows to track additional things outside of these decorators.ENDRELEASENOTES
This PR adds some generic utility functionality to wrap member function calls in between pairs of calls to
std::chrono::high_resolution_clock::now()to calculate how long the execution takes. These utilities, placed in thepodio::benchmarknamespace are then used in the staticTimedWriterandTimedReaderdecorators together with theBenchmarkRecorderclass that takes care of recording the times at different granularities into a root file.In the end, I think, the interface for using this is not too bad, as can be seen by the usage of two newly added tests that use these decorators. Basically, it is necessary to setup a
podio::benchmark::BenchmarkRecorderand pass that to the decorators as first argument during construction. From that point on the decorated reader/writer should work exactly the same as the undecorated ones.