Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully qualify relation return types in generated .cc files #175

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

tmadlener
Copy link
Collaborator

BEGINRELEASENOTES

  • Fully qualify return types for OneToOneRelation getters in generated .cc file for objects and Const objects. This fixes a bug described in Parse multiple yaml files at the same time #168 (comment) and now allows to mix different namespaces in the generated code. This allows to more easily extend already existing datamodels by compiling and linking against them.

ENDRELEASENOTES

Additionally, cleaned up the templates for the OneToOneRelation setters.

@tmadlener
Copy link
Collaborator Author

CI seems to be having problems with the github-action-cvmfs, which seems to be caused by problems accessing the cvmfs package repository at cern: https://github.com/AIDASoft/podio/pull/175/checks?check_run_id=1806087593#step:3:60

@petricm
Copy link

petricm commented Feb 1, 2021

only a transient connection problem

@tmadlener
Copy link
Collaborator Author

triggering CI again.

@tmadlener tmadlener closed this Feb 9, 2021
@tmadlener tmadlener reopened this Feb 9, 2021
@hegner hegner merged commit a5fcde9 into AIDASoft:master Feb 23, 2021
@tmadlener tmadlener deleted the fix-relation-types branch February 23, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants