Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2 from docs #209

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Remove Python 2 from docs #209

merged 2 commits into from
Jan 20, 2022

Conversation

hegner
Copy link
Collaborator

@hegner hegner commented Aug 13, 2021

BEGINRELEASENOTES

  • Remove mention of Python 2 compatibility
    ENDRELEASENOTES

@hegner hegner requested a review from tmadlener August 15, 2021 20:01
@tmadlener
Copy link
Collaborator

Should we enforce a minimum python version also in our cmake config? Currently we require that it is the same as the one that has been used for building root, but that doesn't strictly guarantee > 3.6:

SET(REQUIRE_PYTHON_VERSION ${ROOT_PYTHON_VERSION})

Additionally, we could us the Python::Interpreter target (link) in the generator macro instead of python to avoid running into problems with systems that still have a python that is python2.

@tmadlener tmadlener merged commit fd96daa into master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants