RootIO: ensure podioDict is linked also when linker has as-needed #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @andresailer . I have tested it in the two containers mentioned in #90 and additionally, locally on my Ubuntu machine and on `lxplus. For me it works everywhere. |
|
push-state/pop-state might be better to not affect the behaviour, but for this line here, I don't think it matters? |
andresailer
commented
May 25, 2020
|
The latest version with |
gaede
added a commit
to gaede/EDM4HEP
that referenced
this pull request
May 26, 2020
- needed on Ubuntu (default on others) - follows AIDASoft/podio#91
gaede
added a commit
to key4hep/EDM4hep
that referenced
this pull request
May 26, 2020
- needed on Ubuntu (default on others) - follows AIDASoft/podio#91
tmadlener
pushed a commit
to tmadlener/EDM4hep
that referenced
this pull request
May 27, 2020
- needed on Ubuntu (default on others) - follows AIDASoft/podio#91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tmadlener, can you test this, please
BEGINRELEASENOTES
ENDRELEASENOTES