Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set warn_unused_ignores mypy config to true #1694

Merged
merged 10 commits into from
Aug 20, 2024
Merged

Set warn_unused_ignores mypy config to true #1694

merged 10 commits into from
Aug 20, 2024

Conversation

kumaranvpl
Copy link
Contributor

Description

Please include a summary of the change and specify which issue is being addressed. Additionally, provide relevant motivation and context.

Fixes # (issue number)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples, or any documentation updates)
  • Bug fix (a non-breaking change that resolves an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or feature that would disrupt existing functionality)
  • This change requires a documentation update

Checklist

  • My code adheres to the style guidelines of this project (scripts/lint.sh shows no errors)
  • I have conducted a self-review of my own code
  • I have made the necessary changes to the documentation
  • My changes do not generate any new warnings
  • I have added tests to validate the effectiveness of my fix or the functionality of my new feature
  • Both new and existing unit tests pass successfully on my local environment by running scripts/test-cov.sh
  • I have ensured that static analysis tests are passing by running scripts/static-analysis.sh
  • I have included code examples to illustrate the modifications

@kumaranvpl kumaranvpl linked an issue Aug 19, 2024 that may be closed by this pull request
Enable warn_unused_ignores mypy config #1691
Closed
@kumaranvpl
Copy link
Contributor Author

@Lancetnik I have discrepancy between my local development mypy run and CI's mypy run - https://github.com/airtai/faststream/actions/runs/10449142213/job/28930867234.
Is the same happening to you too? Could you please checkout this branch and run ./scripts/static-analysis.sh?

BTW, I am using python 3.9.19 in my local and CI uses the same too. mypy version is also same too which is version 1.11.1.

davorrunje
davorrunje previously approved these changes Aug 20, 2024
View reviewed changes
@Lancetnik
Copy link
Member

Lancetnik commented Aug 20, 2024 •
edited
Loading

Seems good, but why we have separated static-analysis job now? Can we just run pre-commit in CI without changes?
@kumaranvpl

@kumaranvpl
Copy link
Contributor Author

Seems good, but why we have separated static-analysis job now? Can we just run pre-commit without changes?

Do you mean that instead of running separate static-analysis and pre-commit jobs, I should just run the pre-commit job alone without skipping the static-analysis step?

@Lancetnik
Copy link
Member

Seems good, but why we have separated static-analysis job now? Can we just run pre-commit without changes?

Do you mean that instead of running separate static-analysis and pre-commit jobs, I should just run the pre-commit job alone without skipping the static-analysis step?

I think so, if it is possible

@davorrunje davorrunje added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit f5615d4 Aug 20, 2024
30 checks passed
@davorrunje davorrunje deleted the update-mypy-config branch August 20, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lancetnik Lancetnik Lancetnik approved these changes

@davorrunje davorrunje davorrunje left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable warn_unused_ignores mypy config
3 participants
@kumaranvpl @Lancetnik @davorrunje