diff --git a/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java b/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java index a7aa7ee7ffeab9..4b4678cf9583d8 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java +++ b/src/main/java/com/google/devtools/build/lib/analysis/BuildView.java @@ -417,7 +417,7 @@ public AnalysisResult update( "Analysis succeeded for only %d of %d top-level targets", numSuccessful, numTargetsToAnalyze); eventHandler.handle(Event.info(msg)); - logger.atInfo().log(msg); + logger.atInfo().log("%s", msg); } AnalysisResult result; diff --git a/src/main/java/com/google/devtools/build/lib/buildeventservice/BuildEventServiceModule.java b/src/main/java/com/google/devtools/build/lib/buildeventservice/BuildEventServiceModule.java index 18f471e194c4ad..acfe25f733e057 100644 --- a/src/main/java/com/google/devtools/build/lib/buildeventservice/BuildEventServiceModule.java +++ b/src/main/java/com/google/devtools/build/lib/buildeventservice/BuildEventServiceModule.java @@ -163,7 +163,7 @@ private void reportError( // Don't hide unchecked exceptions as part of the error reporting. Throwables.throwIfUnchecked(exception); - logger.atSevere().withCause(exception).log(msg); + logger.atSevere().withCause(exception).log("%s", msg); reportCommandLineError(commandLineReporter, exception); moduleEnvironment.exit(createAbruptExitException(exception, msg, besCode)); } @@ -254,7 +254,7 @@ private void waitForPreviousInvocation(boolean isShutdown) { + "Cancelling and starting a new invocation...", waitedMillis / 1000, waitedMillis % 1000); reporter.handle(Event.warn(msg)); - logger.atWarning().withCause(exception).log(msg); + logger.atWarning().withCause(exception).log("%s", msg); cancelCloseFutures = true; } catch (ExecutionException e) { String msg; @@ -274,7 +274,7 @@ private void waitForPreviousInvocation(boolean isShutdown) { e.getMessage()); } reporter.handle(Event.warn(msg)); - logger.atWarning().withCause(e).log(msg); + logger.atWarning().withCause(e).log("%s", msg); cancelCloseFutures = true; } finally { if (cancelCloseFutures) { @@ -671,7 +671,7 @@ private BuildEventServiceTransport createBesTransport( String.format( "Build Event Service uploads disabled due to a connectivity problem: %s", status); reporter.handle(Event.warn(message)); - logger.atWarning().log(message); + logger.atWarning().log("%s", message); return null; } diff --git a/src/main/java/com/google/devtools/build/lib/buildeventservice/BuildEventServiceUploader.java b/src/main/java/com/google/devtools/build/lib/buildeventservice/BuildEventServiceUploader.java index 748a6743f07210..16b9e9e98a4d29 100644 --- a/src/main/java/com/google/devtools/build/lib/buildeventservice/BuildEventServiceUploader.java +++ b/src/main/java/com/google/devtools/build/lib/buildeventservice/BuildEventServiceUploader.java @@ -293,7 +293,7 @@ ListenableFuture getHalfCloseFuture() { private DetailedExitCode logAndSetException( String message, BuildProgress.Code bpCode, Throwable cause) { - logger.atSevere().log(message); + logger.atSevere().log("%s", message); DetailedExitCode detailedExitCode = DetailedExitCode.of( FailureDetail.newBuilder() @@ -490,7 +490,7 @@ private void publishBuildEvents() String.format( "Expected ACK with seqNum=%d but received ACK with seqNum=%d", expected.getSequenceNumber(), actualSeqNum); - logger.atInfo().log(message); + logger.atInfo().log("%s", message); streamContext.abortStream(Status.FAILED_PRECONDITION.withDescription(message)); } } else { @@ -498,7 +498,7 @@ private void publishBuildEvents() String.format( "Received ACK (seqNum=%d) when no ACK was expected", ackEvent.getSequenceNumber()); - logger.atInfo().log(message); + logger.atInfo().log("%s", message); streamContext.abortStream(Status.FAILED_PRECONDITION.withDescription(message)); } } @@ -537,7 +537,7 @@ private void publishBuildEvents() if (!shouldRetryStatus(streamStatus)) { String message = String.format("Not retrying publishBuildEvents: status='%s'", streamStatus); - logger.atInfo().log(message); + logger.atInfo().log("%s", message); throw withFailureDetail( streamStatus.asException(), BuildProgress.Code.BES_STREAM_NOT_RETRYING_FAILURE, @@ -548,7 +548,7 @@ private void publishBuildEvents() String.format( "Not retrying publishBuildEvents, no more attempts left: status='%s'", streamStatus); - logger.atInfo().log(message); + logger.atInfo().log("%s", message); throw withFailureDetail( streamStatus.asException(), BuildProgress.Code.BES_UPLOAD_RETRY_LIMIT_EXCEEDED_FAILURE, @@ -636,7 +636,7 @@ private void publishLifecycleEvent(PublishLifecycleEventRequest request) if (!shouldRetryStatus(e.getStatus())) { String message = String.format("Not retrying publishLifecycleEvent: status='%s'", e.getStatus()); - logger.atInfo().log(message); + logger.atInfo().log("%s", message); throw withFailureDetail(e, BuildProgress.Code.BES_STREAM_NOT_RETRYING_FAILURE, message); } diff --git a/src/main/java/com/google/devtools/build/lib/buildeventstream/transports/FileTransport.java b/src/main/java/com/google/devtools/build/lib/buildeventstream/transports/FileTransport.java index 01ab3d10113c43..7bc427d7849342 100644 --- a/src/main/java/com/google/devtools/build/lib/buildeventstream/transports/FileTransport.java +++ b/src/main/java/com/google/devtools/build/lib/buildeventstream/transports/FileTransport.java @@ -186,7 +186,7 @@ private void exitFailure(Throwable e) { .build()), e)); pendingWrites.clear(); - logger.atSevere().withCause(e).log(message); + logger.atSevere().withCause(e).log("%s", message); } private static BuildProgress.Code getBuildProgressCode(Throwable e) { diff --git a/src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java b/src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java index b8ace26283f042..a1927de193d508 100644 --- a/src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java +++ b/src/main/java/com/google/devtools/build/lib/buildtool/ExecutionTool.java @@ -598,7 +598,7 @@ private static void logDeleteTreeFailure( for (Path entry : entries) { directoryDetails.append(" '").append(entry.getBaseName()).append("'"); } - logger.atWarning().log(directoryDetails.toString()); + logger.atWarning().log("%s", directoryDetails); } catch (IOException e) { logger.atWarning().withCause(e).log("'%s' exists but could not be read", directory); } diff --git a/src/main/java/com/google/devtools/build/lib/exec/local/LocalSpawnRunner.java b/src/main/java/com/google/devtools/build/lib/exec/local/LocalSpawnRunner.java index 7decb9357a6934..62c09fce3b8e99 100644 --- a/src/main/java/com/google/devtools/build/lib/exec/local/LocalSpawnRunner.java +++ b/src/main/java/com/google/devtools/build/lib/exec/local/LocalSpawnRunner.java @@ -276,7 +276,7 @@ private void stepLog( Level level, @Nullable Throwable cause, @FormatString String fmt, Object... args) { String msg = String.format(fmt, args); String toLog = String.format("%s (#%d %s)", msg, id, desc()); - logger.at(level).withCause(cause).log(toLog); + logger.at(level).withCause(cause).log("%s", toLog); } private String desc() { diff --git a/src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java b/src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java index 5b857ca0eaced4..ad916d45ab17c8 100644 --- a/src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java +++ b/src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java @@ -820,7 +820,7 @@ public void afterCommand() throws AbruptExitException { failure = e; failureCode = Code.RPC_LOG_FAILURE; failureMessage = "Partially wrote rpc log file"; - logger.atWarning().withCause(e).log(failureMessage); + logger.atWarning().withCause(e).log("%s", failureMessage); } executorService = null; diff --git a/src/main/java/com/google/devtools/build/lib/runtime/BlazeOptionHandler.java b/src/main/java/com/google/devtools/build/lib/runtime/BlazeOptionHandler.java index 57ad0283a3f0c6..bbf7abbb022fcb 100644 --- a/src/main/java/com/google/devtools/build/lib/runtime/BlazeOptionHandler.java +++ b/src/main/java/com/google/devtools/build/lib/runtime/BlazeOptionHandler.java @@ -274,7 +274,7 @@ DetailedExitCode parseStarlarkOptions(CommandEnvironment env, ExtendedEventHandl StarlarkOptionsParser.newStarlarkOptionsParser(env, optionsParser).parse(eventHandler); } catch (OptionsParsingException e) { String logMessage = "Error parsing Starlark options"; - logger.atInfo().withCause(e).log(logMessage); + logger.atInfo().withCause(e).log("%s", logMessage); return processOptionsParsingException( eventHandler, e, logMessage, Code.STARLARK_OPTIONS_PARSE_FAILURE); } @@ -343,7 +343,7 @@ DetailedExitCode parseOptions(List args, ExtendedEventHandler eventHandl } } catch (OptionsParsingException e) { String logMessage = "Error parsing options"; - logger.atInfo().withCause(e).log(logMessage); + logger.atInfo().withCause(e).log("%s", logMessage); return processOptionsParsingException( eventHandler, e, logMessage, Code.OPTIONS_PARSE_FAILURE); } catch (InterruptedException e) { diff --git a/src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java b/src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java index 5ac15090979939..50d7f1b75bac23 100644 --- a/src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java +++ b/src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java @@ -947,7 +947,7 @@ private static int batchMain(Iterable modules, String[] args) { try { logger.atInfo().log( - SafeRequestLogging.getRequestLogString(commandLineOptions.getOtherArgs())); + "%s", SafeRequestLogging.getRequestLogString(commandLineOptions.getOtherArgs())); BlazeCommandResult result = dispatcher.exec( policy, diff --git a/src/main/java/com/google/devtools/build/lib/runtime/BuildSummaryStatsModule.java b/src/main/java/com/google/devtools/build/lib/runtime/BuildSummaryStatsModule.java index daad07acc7d55c..355e3c7dcb3002 100644 --- a/src/main/java/com/google/devtools/build/lib/runtime/BuildSummaryStatsModule.java +++ b/src/main/java/com/google/devtools/build/lib/runtime/BuildSummaryStatsModule.java @@ -138,7 +138,7 @@ public void buildComplete(BuildCompleteEvent event) { event.getResult().getBuildToolLogCollection() .addDirectValue( "critical path", criticalPath.toString().getBytes(StandardCharsets.UTF_8)); - logger.atInfo().log(criticalPath.toString()); + logger.atInfo().log("%s", criticalPath); logger.atInfo().log( "Slowest actions:\n %s", Joiner.on("\n ").join(criticalPathComputer.getSlowestComponents())); diff --git a/src/main/java/com/google/devtools/build/lib/server/GrpcServerImpl.java b/src/main/java/com/google/devtools/build/lib/server/GrpcServerImpl.java index 5a9df0b86687a0..9f73f5a3db5e85 100644 --- a/src/main/java/com/google/devtools/build/lib/server/GrpcServerImpl.java +++ b/src/main/java/com/google/devtools/build/lib/server/GrpcServerImpl.java @@ -545,7 +545,7 @@ private void executeCommand(RunRequest request, BlockingStreamObserver modifiedValues) { diff --git a/src/tools/android/java/com/google/devtools/build/android/desugar/testing/junit/DesugarRunner.java b/src/tools/android/java/com/google/devtools/build/android/desugar/testing/junit/DesugarRunner.java index c2c171c0366fce..aef4a80fb36bd7 100644 --- a/src/tools/android/java/com/google/devtools/build/android/desugar/testing/junit/DesugarRunner.java +++ b/src/tools/android/java/com/google/devtools/build/android/desugar/testing/junit/DesugarRunner.java @@ -267,7 +267,7 @@ static final class VacuousSuccess extends Statement { @Override public void evaluate() throws Throwable { - logger.atWarning().log(reason); + logger.atWarning().log("%s", reason); } @Override diff --git a/src/tools/remote/src/main/java/com/google/devtools/build/remote/worker/ExecutionServer.java b/src/tools/remote/src/main/java/com/google/devtools/build/remote/worker/ExecutionServer.java index f034870abb02f4..c1e23f417af4b0 100644 --- a/src/tools/remote/src/main/java/com/google/devtools/build/remote/worker/ExecutionServer.java +++ b/src/tools/remote/src/main/java/com/google/devtools/build/remote/worker/ExecutionServer.java @@ -331,7 +331,7 @@ private ActionResult execute( String.format( "Command:\n%s\nexceeded deadline of %f seconds.", Arrays.toString(command.getArgumentsList().toArray()), timeoutMillis / 1000.0); - logger.atWarning().log(errMessage); + logger.atWarning().log("%s", errMessage); errStatus = Status.newBuilder() .setCode(Code.DEADLINE_EXCEEDED.getNumber())