fix(popover): run markForCheck to detect changes if nb-layout has onP…

…ush (#267) Closes #266
akveo · Feb 22, 2018 · 7af0f62 · 7af0f62
1 parent 6e59b84
commit 7af0f62
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/app/popover-test/popover-test.component.ts b/src/app/popover-test/popover-test.component.ts
@@ -4,11 +4,12 @@
  * Licensed under the MIT License. See License.txt in the project root for license information.
  */
 
-import { Component } from '@angular/core';
+import { ChangeDetectionStrategy, Component } from '@angular/core';
 import { NbDynamicToAddComponent } from '../layout-test/theme-dynamic-test.component';
 
 @Component({
   selector: 'nb-popover-test',
+  changeDetection: ChangeDetectionStrategy.OnPush,
   template: `
     <nb-layout>
       <nb-layout-column>

diff --git a/src/framework/theme/components/popover/popover.directive.ts b/src/framework/theme/components/popover/popover.directive.ts
@@ -240,6 +240,7 @@ export class NbPopoverDirective implements OnInit, OnDestroy {
          * which will call {@link NbThemeService#appendToLayoutTop} and 'do' detectChanges,
          * instead of performing this call by service client.
          * */
+        this.containerRef.changeDetectorRef.markForCheck();
         this.containerRef.changeDetectorRef.detectChanges();
         this.place();
       });