Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): add RTL chevron menu icon #1042

Merged
merged 18 commits into from
Apr 19, 2019

Conversation

V-Ahmetvaliev
Copy link
Contributor

also change ion to nb icon

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

also change ion to nb icon
@nnixaa
Copy link
Collaborator

nnixaa commented Dec 4, 2018

@V-Ahmetvaliev @yggg shouldn't we subscribe to changes and change the template based on it?

@V-Ahmetvaliev V-Ahmetvaliev removed the WIP label Dec 5, 2018
Tibing
Tibing previously requested changes Dec 6, 2018
src/framework/theme/components/menu/menu.component.ts Outdated Show resolved Hide resolved
docs/app/@theme/styles/styles.scss Outdated Show resolved Hide resolved
src/framework/theme/components/menu/menu.spec.ts Outdated Show resolved Hide resolved
@nnixaa nnixaa added this to the 4.0.0 milestone Jan 11, 2019
@nnixaa nnixaa added the blocked label Jan 11, 2019
nnixaa
nnixaa previously approved these changes Jan 11, 2019
@yggg yggg changed the base branch from master to next April 18, 2019 14:13
@yggg yggg requested a review from nnixaa April 18, 2019 14:29
@yggg yggg removed the blocked label Apr 18, 2019
BREAKING CHANGE:

Collapsed menu icon changes direction based on current layout direction.
@yggg yggg dismissed their stale review April 18, 2019 14:43

oudated

@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

Merging #1042 into next will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##             next    #1042      +/-   ##
==========================================
+ Coverage   82.56%   82.58%   +0.01%     
==========================================
  Files         237      237              
  Lines        7274     7281       +7     
  Branches      635      637       +2     
==========================================
+ Hits         6006     6013       +7     
  Misses       1080     1080              
  Partials      188      188
Impacted Files Coverage Δ
.../framework/theme/components/menu/menu.component.ts 72.8% <100%> (+1.61%) ⬆️

@yggg yggg merged commit 518d61f into akveo:next Apr 19, 2019
yggg pushed a commit that referenced this pull request May 27, 2019
BREAKING CHANGE:

Collapsed menu icon changes direction based on current layout direction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants