Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): set document dir directly #1164

Merged
merged 2 commits into from
Jan 25, 2019
Merged

fix(layout): set document dir directly #1164

merged 2 commits into from
Jan 25, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jan 17, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes rendering on server. As pointed out on stackoverflow, renderer should be used only with elements.
Closes #1144.

As pointed out stackoverflow.com/questions/54088021, renderer should be
used only for element.
@yggg yggg requested a review from nnixaa January 17, 2019 08:34
@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #1164 into master will decrease coverage by 0.69%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #1164     +/-   ##
=========================================
- Coverage   79.54%   78.84%   -0.7%     
=========================================
  Files         202      200      -2     
  Lines        6262     6070    -192     
  Branches      498      469     -29     
=========================================
- Hits         4981     4786    -195     
- Misses       1165     1169      +4     
+ Partials      116      115      -1
Impacted Files Coverage Δ
...mework/theme/components/layout/layout.component.ts 76.16% <100%> (ø) ⬆️
...work/theme/components/popover/popover.directive.ts 86.88% <0%> (-4.3%) ⬇️
...work/theme/components/popover/popover.component.ts 100% <0%> (ø) ⬆️
...rc/framework/theme/components/cdk/overlay/index.ts 100% <0%> (ø) ⬆️
.../theme/components/cdk/overlay/overlay-container.ts 100% <0%> (ø) ⬆️
...nts/cdk/overlay/dynamic/dynamic-overlay-handler.ts
.../components/cdk/overlay/dynamic/dynamic-overlay.ts
...eme/components/calendar/base-calendar.component.ts 77.77% <0%> (+2.22%) ⬆️

@nnixaa nnixaa merged commit 37eaea7 into akveo:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultServerRenderer2.setProperty error in SSR angular universal
2 participants