Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): start from date typed in input #1300

Merged
merged 7 commits into from
Mar 14, 2019
Merged

fix(datepicker): start from date typed in input #1300

merged 7 commits into from
Mar 14, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Mar 13, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes #1081 (not initial issue but comment)

@yggg yggg requested a review from nnixaa March 13, 2019 19:24
@yggg yggg mentioned this pull request Mar 13, 2019
2 tasks
Copy link
Collaborator

@nnixaa nnixaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of tests?

@yggg
Copy link
Contributor Author

yggg commented Mar 14, 2019

Couple of tests?

@nnixaa ce3c032

@nnixaa nnixaa self-requested a review March 14, 2019 12:54
@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #1300 into master will increase coverage by 0.61%.
The diff coverage is 90.32%.

@@            Coverage Diff             @@
##           master    #1300      +/-   ##
==========================================
+ Coverage   79.98%   80.59%   +0.61%     
==========================================
  Files         232      232              
  Lines        7033     7051      +18     
  Branches      590      592       +2     
==========================================
+ Hits         5625     5683      +58     
+ Misses       1241     1192      -49     
- Partials      167      176       +9
Impacted Files Coverage Δ
...ndar-year-picker/calendar-year-picker.component.ts 94.44% <100%> (+0.15%) ⬆️
.../theme/components/calendar-kit/components/index.ts 100% <100%> (ø) ⬆️
...heme/components/datepicker/datepicker.component.ts 89.83% <100%> (+5.9%) ⬆️
...eme/components/calendar/base-calendar.component.ts 75.55% <50%> (ø) ⬆️
...ar-month-picker/calendar-month-picker.component.ts 75.75% <50%> (+1.56%) ⬆️
...heme/components/datepicker/datepicker.directive.ts 80.32% <0%> (+0.81%) ⬆️
...lendar-day-picker/calendar-day-picker.component.ts 100% <0%> (+7.14%) ⬆️
.../theme/components/calendar/calendar-range-cells.ts 75% <0%> (+16.17%) ⬆️
...me/components/calendar/calendar-range.component.ts 87.5% <0%> (+35.41%) ⬆️

@yggg yggg merged commit dfc75f0 into akveo:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nb-datepicker with inputed date
2 participants