chore: update angular #1449
Merged
chore: update angular #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent compiler warning
CDK FlexibleConnectedPositionStrategy changed and now it getting overlay container dimensions during updatePosition. It updates position after showing overlay and angular zone becomes stable only if overlay still attached. Call hide on select to detach overlay so no update position performed.
Looks like it's required now
Required by Angular CLI 8
Sass stopped supporting this. Refactor to set input status if file over.
Codecov Report
@@ Coverage Diff @@
## master #1449 +/- ##
==========================================
+ Coverage 82.83% 82.95% +0.11%
==========================================
Files 240 240
Lines 7323 7332 +9
Branches 656 659 +3
==========================================
+ Hits 6066 6082 +16
+ Misses 1067 1060 -7
Partials 190 190
|
Interpolation isn't supported in keyframes name
Add test to pass coverage check on pull request. Chat form input status logic was moved from css to ts during angular update since scss @extend now doesn't support compound selectors.
yggg
added a commit
that referenced
this pull request
May 27, 2019
Limitation: For the time being Nebular doesn't have ES2015 bundle and therefore can't be used in packages with target ES2015 (this target set in tsconfig by default in Angular 8). You have to manually change target es5. BREAKING CHANGE: Angular 8+ now required
yggg
added a commit
that referenced
this pull request
Jun 6, 2019
Limitation: For the time being Nebular doesn't have ES2015 bundle and therefore can't be used in packages with target ES2015 (this target set in tsconfig by default in Angular 8). You have to manually change target es5. BREAKING CHANGE: Angular 8+ now required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Limitation:
For the time being Nebular doesn't have ES2015 bundle and therefore can't be used in packages with target ES2015 (this target set in tsconfig by default in Angular 8). You have to manually change target es5.
BREAKING CHANGE:
Angular 8+ now required