Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typography): specify body, paragraph and list styles #1546

Merged
merged 6 commits into from
May 31, 2019
Merged

feat(typography): specify body, paragraph and list styles #1546

merged 6 commits into from
May 31, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented May 30, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@yggg yggg requested a review from nnixaa May 30, 2019 18:19
nnixaa
nnixaa requested changes May 30, 2019
View reviewed changes
Copy link
Collaborator

@nnixaa nnixaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update also variables in components

@yggg
Copy link
Contributor Author

yggg commented May 30, 2019

@nnixaa done in bf6ef49

nnixaa
nnixaa approved these changes May 30, 2019
View reviewed changes
Copy link
Collaborator

@nnixaa nnixaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's change the commit message to feat(list): since the changes are related to list component.

@yggg
Copy link
Contributor Author

yggg commented May 30, 2019 •
edited
Loading

But this PR also has changes for body and paragraph.

@yggg yggg merged commit 310127b into akveo:master May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnixaa nnixaa nnixaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yggg @nnixaa