Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): path fragment comparison #1809

Merged
merged 3 commits into from
Jul 12, 2019
Merged

fix(menu): path fragment comparison #1809

merged 3 commits into from
Jul 12, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Jul 12, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Described in #1660 (comment)

@yggg yggg requested a review from Tibing July 12, 2019 10:27
@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

Merging #1809 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1809   +/-   ##
=======================================
  Coverage   83.91%   83.91%           
=======================================
  Files         232      232           
  Lines        7568     7568           
  Branches      665      665           
=======================================
  Hits         6351     6351           
  Misses       1023     1023           
  Partials      194      194
Impacted Files Coverage Δ
...rc/framework/theme/components/menu/menu.service.ts 87.32% <100%> (ø) ⬆️

@yggg yggg merged commit abbd659 into akveo:master Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants