Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidebar service): add compact method #1997

Merged
merged 3 commits into from
Oct 4, 2019
Merged

feat(sidebar service): add compact method #1997

merged 3 commits into from
Oct 4, 2019

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Oct 4, 2019

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

@yggg yggg requested a review from nnixaa October 4, 2019 13:08
@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

Merging #1997 into master will increase coverage by <.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #1997      +/-   ##
==========================================
+ Coverage   84.06%   84.07%   +<.01%     
==========================================
  Files         235      235              
  Lines        7794     7803       +9     
  Branches      681      682       +1     
==========================================
+ Hits         6552     6560       +8     
  Misses       1042     1042              
- Partials      200      201       +1
Impacted Files Coverage Δ
...mework/theme/components/sidebar/sidebar.service.ts 84% <100%> (+4%) ⬆️
...work/theme/components/sidebar/sidebar.component.ts 54.92% <75%> (+0.58%) ⬆️

@yggg yggg merged commit 3c34805 into akveo:master Oct 4, 2019
@yggg yggg deleted the feat/sidebar-service-add-compact-method branch October 4, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants