Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(theme): remove user context menu #231

Merged
merged 3 commits into from
Feb 20, 2018
Merged

Conversation

Tibing
Copy link
Member

@Tibing Tibing commented Feb 14, 2018

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Remove user component context menu. User context menu example will be created in the ngx-admin with popover component.

nnixaa
nnixaa previously approved these changes Feb 20, 2018
@nnixaa
Copy link
Collaborator

nnixaa commented Feb 20, 2018

@Tibing commit message should contain a BREAKING CHANGE note, also, regenerate the documentation please

BREAKING CHANGES: NbUserComponent no longer has context menu. We've
completely moved context menu in the separate component. So, to
migrate from the previous version you have to remove user menu items
```
<nb-user [menu]="items"></nb-user>
```
and use NbContextMenuDirective:
```
<nb-user [nbContextMenu]="items"></nb-user>
```
@nnixaa nnixaa merged commit 959bd4a into akveo:master Feb 20, 2018
dimaatkaev pushed a commit to dimaatkaev/nebular that referenced this pull request Feb 21, 2018
BREAKING CHANGES: NbUserComponent no longer has context menu. We've
completely moved context menu in the separate component. So, to
migrate from the previous version you have to remove user menu items
```
<nb-user [menu]="items"></nb-user>
```
and use NbContextMenuDirective:
```
<nb-user [nbContextMenu]="items"></nb-user>
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants