Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): provide ES5 code in UMD bundles #2520

Merged
merged 2 commits into from
Sep 23, 2020
Merged

fix(build): provide ES5 code in UMD bundles #2520

merged 2 commits into from
Sep 23, 2020

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Sep 22, 2020

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2469

@ghost
Copy link

ghost commented Sep 22, 2020

DeepCode's analysis on #849ec5 found:

  • ℹ️ 1 minor issue. 👇

Top issues

Description Example fixes
Type declaration of 'any' loses type-safety. Consider replacing it with a more precise type. Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@codecov
Copy link

codecov bot commented Sep 23, 2020

Codecov Report

Merging #2520 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2520      +/-   ##
==========================================
+ Coverage   78.92%   78.96%   +0.03%     
==========================================
  Files         253      253              
  Lines        7774     7774              
  Branches      852      852              
==========================================
+ Hits         6136     6139       +3     
+ Misses       1376     1372       -4     
- Partials      262      263       +1     
Impacted Files Coverage Δ
...ramework/theme/components/toastr/toastr.service.ts 97.39% <0.00%> (+2.60%) ⬆️

@yggg yggg merged commit e64bac0 into akveo:master Sep 23, 2020
@yggg yggg deleted the fix/build-umd-bundle branch September 23, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nebular/theme v6.0.0 error during ngcc post-install
1 participant