-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autocomplete): input focus behavior on value change #2852
Merged
yggg
merged 11 commits into
akveo:master
from
katebatura:fix/2401-autocomplete_focus_behavior
Nov 15, 2021
Merged
fix(autocomplete): input focus behavior on value change #2852
yggg
merged 11 commits into
akveo:master
from
katebatura:fix/2401-autocomplete_focus_behavior
Nov 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yggg
suggested changes
Sep 14, 2021
src/framework/theme/components/autocomplete/autocomplete.directive.ts
Outdated
Show resolved
Hide resolved
katebatura
changed the title
fix(nb-autocomplete): input focus behavior on value change
fix(autocomplete): input focus behavior on value change
Sep 14, 2021
katebatura
changed the title
fix(autocomplete): input focus behavior on value change
BREAKING CHANGE(autocomplete): input focus behavior on value change
Sep 16, 2021
katebatura
changed the title
BREAKING CHANGE(autocomplete): input focus behavior on value change
fix(autocomplete): input focus behavior on value change
Sep 16, 2021
yggg
approved these changes
Sep 16, 2021
yggg
suggested changes
Nov 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we also focus input when selecting option by enter (handleInputValueUpdate
call from the subscribeOnOverlayKeys
method)?
…vior' into fix/2401-autocomplete_focus_behavior
yggg
approved these changes
Nov 15, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Closes #2401
Focus behavior when a value is set to the input bound to an Autocomplete:
BREAKING CHANGE:
Removed
focusInputOnValueChange
fromNbAutocompleteDirective
. Now autocomplete focuses input only when value is selected by option click or keyboard selection.