feat(menu): apply default values for menuItems #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnixaa
requested changes
Apr 3, 2018
|
|
||
| ngOnInit() { | ||
| this.menuService | ||
| .onItemClick() | ||
| .pipe(takeWhile(() => this.alive)) | ||
| .subscribe((data: { tag: string; item: NbMenuItem }) => console.info(data)); | ||
| .subscribe((data: { tag: string; item: NbMenuItem }) => {}); // console.info(data)); |
There was a problem hiding this comment.
what's the meaning of this change?
| (exact && location === item.link) || | ||
| (!exact && location.includes(item.link)) || | ||
| (exact && item.fragment && location.substr(location.indexOf('#') + 1).includes(item.fragment)) | ||
| const selected = ( |
There was a problem hiding this comment.
how about we divide this logic into smaller helpers or even a separate helper class? and create a unit test for it.
mishkolesnikov
force-pushed
the
feature/menu-items-defaults
branch
from
9350d58
to
2818682
Compare
mishkolesnikov
force-pushed
the
feature/menu-items-defaults
branch
from
2818682
to
36a2e91
Compare
BREAKING CHANGES: URL fragment no longer affect menu items selection. Now we olny find mathes between path part of the URL and `link` property of menu-item.
mishkolesnikov
force-pushed
the
feature/menu-items-defaults
branch
from
36a2e91
to
da792c6
Compare
nnixaa
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply defaults for menu items