Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): run change detection after setting initial value #898

Merged
merged 2 commits into from
Oct 16, 2018
Merged

fix(select): run change detection after setting initial value #898

merged 2 commits into from
Oct 16, 2018

Conversation

yggg
Copy link
Contributor

@yggg yggg commented Oct 12, 2018

Fixes ExpressionChangedAfterItHasBeenCheckedError.

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Fixes ExpressionChangedAfterItHasBeenCheckedError

Fixes ExpressionChangedAfterItHasBeenCheckedError.
@codecov
Copy link

codecov bot commented Oct 12, 2018

Codecov Report

Merging #898 into master will decrease coverage by 0.03%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
- Coverage   76.79%   76.75%   -0.04%     
==========================================
  Files         201      201              
  Lines        5963     5967       +4     
  Branches      454      454              
==========================================
+ Hits         4579     4580       +1     
- Misses       1278     1282       +4     
+ Partials      106      105       -1
Impacted Files Coverage Δ
...mework/theme/components/select/select.component.ts 84.18% <0%> (-0.48%) ⬇️
...ponents/accordion/accordion-item-body.component.ts 50% <0%> (-8.83%) ⬇️
src/framework/theme/theme.module.ts 95.23% <0%> (+4.76%) ⬆️

@nnixaa nnixaa requested a review from Tibing October 15, 2018 09:57
@Tibing
Copy link
Member

Tibing commented Oct 15, 2018

Hi @yggg , how may I reproduce ExpressionChangedAfterItHasBeenCheckedError?

@yggg
Copy link
Contributor Author

yggg commented Oct 15, 2018

@Tibing

<nb-select [(selected)]="value">
  <nb-option *ngFor="...">
</nb-select>

@nnixaa nnixaa merged commit 5cf94f2 into akveo:master Oct 16, 2018
@mahnuh
Copy link

mahnuh commented Dec 7, 2018

@yggg @Tibing Is this fix available in v3.0.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants