Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove separate GitHub API call just to check if user exists #41

Closed
alexpovel opened this issue Aug 13, 2022 · 0 comments · Fixed by #42
Closed

Remove separate GitHub API call just to check if user exists #41

alexpovel opened this issue Aug 13, 2022 · 0 comments · Fixed by #42
Assignees
@alexpovel
Labels
bug Something isn't working enhancement New feature or request
Milestone
anc.v1

Comments

@alexpovel
Copy link
Owner

This:

ancv/ancv/web/client.py

Line 35 in c9fbd48

await github.getitem(f"/users/{user}")

is really bad. It basically halves our API rate limit and costs a ton of time:

image

Here, it alone doubles our response time (Server-Timing from #37 ).
@alexpovel alexpovel added bug Something isn't working enhancement New feature or request labels Aug 13, 2022
@alexpovel alexpovel added this to the anc.v1 milestone Aug 13, 2022
@alexpovel alexpovel self-assigned this Aug 13, 2022
@github-actions github-actions bot mentioned this issue Aug 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexpovel alexpovel

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
anc.v1
Development

Successfully merging a pull request may close this issue.

chore(main): release 0.12.0 alexpovel/ancv
1 participant
@alexpovel