From 099c909abc7a24ecefee93651fd3e245d13b279a Mon Sep 17 00:00:00 2001 From: Mykola Harmash Date: Wed, 8 May 2024 16:50:37 +0200 Subject: [PATCH 1/2] [Onboarding] Scroll to the top on the page when navigating to a quick start view (#182844) Closes https://github.com/elastic/kibana/issues/182157 - Adds a hook to watch for location path updates reset the page's scroll position --- .../public/application/experimental_onboarding_flow.tsx | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/x-pack/plugins/observability_solution/observability_onboarding/public/application/experimental_onboarding_flow.tsx b/x-pack/plugins/observability_solution/observability_onboarding/public/application/experimental_onboarding_flow.tsx index 265e1cf8104763..f3eac583034258 100644 --- a/x-pack/plugins/observability_solution/observability_onboarding/public/application/experimental_onboarding_flow.tsx +++ b/x-pack/plugins/observability_solution/observability_onboarding/public/application/experimental_onboarding_flow.tsx @@ -7,7 +7,7 @@ import { i18n } from '@kbn/i18n'; import { QueryClient, QueryClientProvider } from '@tanstack/react-query'; -import React from 'react'; +import React, { useEffect } from 'react'; import { Route, Routes } from '@kbn/shared-ux-router'; import { useNavigate, useLocation } from 'react-router-dom-v5-compat'; import { EuiButtonEmpty, EuiPageTemplate, EuiSpacer } from '@elastic/eui'; @@ -22,6 +22,12 @@ import { CustomLogsPanel } from './quickstart_flows/custom_logs'; const queryClient = new QueryClient(); export function ExperimentalOnboardingFlow() { + const { pathname } = useLocation(); + + useEffect(() => { + window.scrollTo(0, 0); + }, [pathname]); + return ( Date: Wed, 8 May 2024 17:00:52 +0200 Subject: [PATCH 2/2] [ML] Enable transform health rule API tests (#182560) ## Summary Closes https://github.com/elastic/kibana/issues/177215 ### Checklist - [x] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --- .../group2/transform_rule_types/transform_health/rule.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/transform_rule_types/transform_health/rule.ts b/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/transform_rule_types/transform_health/rule.ts index 318b8f99a61e0f..d5a03d3d66cecb 100644 --- a/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/transform_rule_types/transform_health/rule.ts +++ b/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group2/transform_rule_types/transform_health/rule.ts @@ -23,6 +23,7 @@ import { TRANSFORM_HEALTH_RESULTS } from '@kbn/transform-plugin/common/constants import { FtrProviderContext } from '../../../../../../common/ftr_provider_context'; import { getUrlPrefix, ObjectRemover } from '../../../../../../common/lib'; import { Spaces } from '../../../../../scenarios'; +import { runSoon } from '../../../group3/test_helpers'; const CONNECTOR_TYPE_ID = '.index'; const RULE_TYPE_ID = 'transform_health'; @@ -30,7 +31,7 @@ const ES_TEST_INDEX_SOURCE = 'transform-alert:transform-health'; const ES_TEST_INDEX_REFERENCE = '-na-'; const ES_TEST_OUTPUT_INDEX_NAME = `${ES_TEST_INDEX_NAME}-ts-output`; -const RULE_INTERVAL_SECONDS = 3; +const RULE_INTERVAL_SECONDS = 10000; interface CreateRuleParams { name: string; @@ -80,8 +81,7 @@ export default function ruleTests({ getService }: FtrProviderContext) { `.internal.alerts-transform.health.alerts-default-000001` ); - // Failing: See https://github.com/elastic/kibana/issues/177215 - describe.skip('rule', async () => { + describe('rule', async () => { const objectRemover = new ObjectRemover(supertest); let connectorId: string; const transformId = 'test_transform_01'; @@ -121,6 +121,8 @@ export default function ruleTests({ getService }: FtrProviderContext) { await stopTransform(transformId); + await runSoon({ id: ruleId, supertest, retry }); + log.debug('Checking created alerts...'); const docs = await waitForDocs(1);