Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant block argument from Indexer client. #475

Open
tzaffi opened this issue May 8, 2023 · 0 comments
Open

Remove redundant block argument from Indexer client. #475

tzaffi opened this issue May 8, 2023 · 0 comments
Labels
new-feature-request Feature request that needs triage Team Lamprey

Comments

@tzaffi
Copy link
Contributor

tzaffi commented May 8, 2023 •
edited
Loading

Problem

The indexer client accepts redundant and error-causing parameters in a few of its methods. In particular:

  • in several places the synonomous block and round_num are accepted. EG here
  • in several places we alert users with DO NOT USE a particular param. EG here

Solution

Remove the offending parameters. As this is a breaking change, we may want to include it into a V3 upgrade.
We can start by deprecating usage ASAP.

Related Issues

#471

Urgency

Medium - this is mostly a nuisance, but it does cause confusion
@tzaffi tzaffi added the new-feature-request Feature request that needs triage label May 8, 2023
@tzaffi tzaffi mentioned this issue May 8, 2023
Merged
@winder winder changed the title Indexer: Small breaking changes required Remove redundant block argument from Indexer client. Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new-feature-request Feature request that needs triage Team Lamprey
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tzaffi @algoanne