Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot parse block_info transactions into SignedTransaction objects #528

Open
grzracz opened this issue Jan 20, 2024 · 2 comments
Open

Cannot parse block_info transactions into SignedTransaction objects #528

grzracz opened this issue Jan 20, 2024 · 2 comments
Assignees
Labels
new-bug Bug report that needs triage

Comments

@grzracz
Copy link
Contributor

grzracz commented Jan 20, 2024

Subject of the issue

SignedTransaction.undictify does not work on block_info transactions from block_info().block.txns

Steps to reproduce

  1. Fetch block_info using Algod client
  2. Try to parse transaction for transactions using SignedTransaction.undictify

Expected behaviour

Transactions get parsed into objects. Potential solution could be to have an additional method that parses the entire block into readable data.

Actual behaviour

Bunch of errors where undictify assumed keys are bytes and not base64 encoded strings

@grzracz grzracz added the new-bug Bug report that needs triage label Jan 20, 2024
@grzracz
Copy link
Contributor Author

grzracz commented Jan 20, 2024

In order to make this any useful Transaction object would also need to include state deltas

@jannotti
Copy link
Contributor

#531 is working on this.

Rather than changing Transaction, it adds SignedTxnWithAD which is the name of the structure that contains the Transaction, signature, and ApplyData in the Go code.

@jannotti jannotti self-assigned this Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-bug Bug report that needs triage
Projects
None yet
Development

No branches or pull requests

2 participants