Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

替换ThreadLocal<SimpleDateFormat>以适配Java21虚拟线程 #3321

Closed
shichaoyuan opened this issue Jan 31, 2024 · 1 comment · Fixed by #3353
Closed

替换ThreadLocal<SimpleDateFormat>以适配Java21虚拟线程 #3321

shichaoyuan opened this issue Jan 31, 2024 · 1 comment · Fixed by #3353

Comments

@shichaoyuan
Copy link
Contributor

Issue Description

Sentinel/sentinel-core/src/main/java/com/alibaba/csp/sentinel/eagleeye/EagleEyeCoreUtils.java

Lines 142 to 148 in a524ab3

private static final ThreadLocal<FastDateFormat> dateFmt = new ThreadLocal<FastDateFormat>() {
@Override
protected FastDateFormat initialValue() {
return new FastDateFormat();
}
};

Sentinel/sentinel-core/src/main/java/com/alibaba/csp/sentinel/log/jul/CspFormatter.java

Lines 28 to 34 in a524ab3

private final ThreadLocal<SimpleDateFormat> dateFormatThreadLocal = new ThreadLocal<SimpleDateFormat>() {
@Override
public SimpleDateFormat initialValue() {
return new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS");
}
};

Sentinel/sentinel-core/src/main/java/com/alibaba/csp/sentinel/log/jul/DateFileLogHandler.java

Lines 36 to 42 in a524ab3

private final ThreadLocal<SimpleDateFormat> dateFormatThreadLocal = new ThreadLocal<SimpleDateFormat>() {
@Override
public SimpleDateFormat initialValue() {
return new SimpleDateFormat("yyyy-MM-dd");
}
};

代码中的ThreadLocal对Java21中的 virtual thread 并不友好。

而且从Java8开始已经推荐使用 java.time.format.DateTimeFormatter，这是一个 "This class is immutable and thread-safe." 的实现。

Describe your initial design

是否可以将这些地方换成 java.time.format.DateTimeFormatter？

如果可以的话，我愿意提PR
@robberphex
Copy link
Collaborator

robberphex commented Feb 28, 2024 •
edited
Loading

是可以这样修改的，欢迎提交这个PR。

@shichaoyuan shichaoyuan mentioned this issue Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

替换ThreadLocal<SimpleDateFormat>以适配Java21虚拟线程 shichaoyuan/Sentinel
2 participants
@shichaoyuan @robberphex