Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Golang version of the existing CPP Wasm plugin: custom-response #592

Closed
WeixinX opened this issue Oct 20, 2023 · 5 comments · Fixed by #689
Closed

Implement the Golang version of the existing CPP Wasm plugin: custom-response #592

WeixinX opened this issue Oct 20, 2023 · 5 comments · Fixed by #689

Comments

@WeixinX
Copy link
Collaborator

WeixinX commented Oct 20, 2023

No description provided.

@cr7258
Copy link
Collaborator

cr7258 commented Nov 15, 2023

I want to implement custom-response plugin in Go. However, it seems to overlap with the transformer plugin.
Besides custom HTTP response status code (status_code) and enabling on specific status (enable_on_status), the transformer plugin offers all features of the custom-response plugin plus added functionality.

Should we deprecate custom-response plugin and instead incorporate the status_code and enable_on_status functionalities in the transformer plugin?

@WeixinX
Copy link
Collaborator Author

WeixinX commented Nov 18, 2023

@cr7258

I think custom-response and transformer are fundamentally different.

The former is used to mock responses, while the latter is used to modify response information, depending on whether the request reaches the backend service or not.

@cr7258
Copy link
Collaborator

cr7258 commented Nov 18, 2023

@WeixinX Thanks for your explanation. I'll try to implement the custom-response plugin. Please assign the issue to me, thanks.

@johnlanni
Copy link
Collaborator

@cr7258 Hello 👋 Se7en, please join this Dingtalk group, welcome to participate in the discussion:
image

@cr7258
Copy link
Collaborator

cr7258 commented Dec 13, 2023

@johnlanni Thanks, joined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants