From c350c57bd6c2af316f9abb9b8271b9c90a42b4fe Mon Sep 17 00:00:00 2001 From: qicosmos Date: Fri, 28 Jun 2024 11:33:50 +0800 Subject: [PATCH] fix output of histogram (#700) --- include/ylt/metric/histogram.hpp | 2 +- src/metric/tests/test_metric.cpp | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/include/ylt/metric/histogram.hpp b/include/ylt/metric/histogram.hpp index 69f8c3cb3..a47d3ae4f 100644 --- a/include/ylt/metric/histogram.hpp +++ b/include/ylt/metric/histogram.hpp @@ -213,7 +213,7 @@ class histogram_t : public metric_t { for (size_t i = 0; i < bucket_counts.size(); i++) { auto counter = bucket_counts[i]; value_str.append(name_).append("_bucket{"); - build_label_string(str, sum_->labels_name(), labels_value); + build_label_string(value_str, sum_->labels_name(), labels_value); value_str.append(","); if (i == bucket_boundaries_.size()) { diff --git a/src/metric/tests/test_metric.cpp b/src/metric/tests/test_metric.cpp index f820eb946..07cbf68c6 100644 --- a/src/metric/tests/test_metric.cpp +++ b/src/metric/tests/test_metric.cpp @@ -538,6 +538,11 @@ TEST_CASE("test get metric by static labels and label") { h1->observe({"GET", "/"}, 23); + std::string str1; + h1->serialize(str1); + std::cout << str1; + CHECK(str1.find("method=\"GET\",url=\"/\",le=") != std::string::npos); + auto s1 = metric_mgr::create_metric_static( "http_req_static_summary", "help", summary_t::Quantiles{