feat: Add width and valign attributes for cleaner <td>
#344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenshiAMD
approved these changes
Oct 10, 2022
tenshiAMD
changed the title
width and valign attributes to <td> for cleaner lookswidth and valign attributes for cleaner <td> (#344)
tenshiAMD
changed the title
width and valign attributes for cleaner <td> (#344)width and valign attributes for cleaner <td>
|
🎉 This PR is included in version 6.24.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@all-contributors please add @qyurila for code |
|
I've put up a pull request to add @qyurila! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
This PR improves the looks of contributors table to each cells have more constant width and avatars are vertically aligned.
Why:
Currently the table looks not very clean not only on mobile or small screen, but also on large screen depending
contributorsPerLinevalue, if it's viewed on main page of repo. (relevant issue: #173)How:
This PR adds
widthandvalignattributes to contributor cells of the table.widthis calculated by dividing 100% bycontributorsPerLine.valignis set totop, for better avatar align.Checklist:
Additional Comment:
#173 might needs to be not closed or reopened later, because technically this PR doesn't make noticable visual improvement for mobile view.