Skip to content
This repository has been archived by the owner on Dec 16, 2022. It is now read-only.

Max Pooling Entity Extractor #5449

Closed
MSLars opened this issue Oct 27, 2021 · 1 comment · Fixed by #5520
Closed

Max Pooling Entity Extractor #5449

MSLars opened this issue Oct 27, 2021 · 1 comment · Fixed by #5520

Comments

@MSLars
Copy link
Contributor

MSLars commented Oct 27, 2021

Several relation extraction approaches receive span representations through a max-pooling operation
Implementing such approaches (E.g. RE-AGCN in lines 69 and 70) could benefit from a new module.

@SpanExtractor.register("max_pooling")
class MaxPoolingSpanExtractor(SpanExtractorWithSpanWidthEmbedding):

Currently, I can't find such a component or a related feature request and I would offer to prepare a Merge Request if the idea seems useful.

@epwalsh
Copy link
Member

epwalsh commented Oct 29, 2021

Hi @MSLars, once you have a working implementation feel free to open a pull request.

@MSLars MSLars mentioned this issue Dec 20, 2021
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants