Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags only apply one file at a time #491

Open
Max-Hollywood opened this issue Jul 4, 2022 · 3 comments
Open

Tags only apply one file at a time #491

Max-Hollywood opened this issue Jul 4, 2022 · 3 comments

Comments

@Max-Hollywood
Copy link

Max-Hollywood commented Jul 4, 2022

Hey, I love Allusion it's awesome.

Describe the bug
Tags only apply to one file at a time, instead of all selected files.

I was testing it out with a number of small folders for D&D, and no problems, but then I started adding larger folders, and all my holiday photoes (we are talking multiple thousands of photoes) and it was having trouble keeping up but it got there with a bit of patience. Today, I tried to tag multiple files but it would only do one file at a time.

So with say 100 files selected, I'd drag over the "holiday" tag, and it would apply to the first image.
I'd drag over "holiday" again, and it would apply to the second image.
If I now drag over the "2014" tag, it would apply to the first, second, and third images.
Using "2014" tag again, it applies to the fourth image.
Using "holiday" again, it applies to the third, fourth, and fifth image.

So it acts normal up to the "current" image, which only increments one at a time when the action is processed, instead of the entire selection.

Feature request: It would be great (if there is a file limit) to toggle on and off the added Locations, since deleting them from Allusion removes tag information, and to speed up the app when processing large amounts of files.

To Reproduce
Steps to reproduce the behavior:

  1. Select any number of files.
  2. Drag a tag over them, or use the tag selector.
  3. Tag is only applied to the "current" file, or if a different tag is used it applies it to the "current" and the "next" file.

Expected behavior
The tag to be applied to all selected files.

Allusion version

  • v1.0.0-rc8.1

Desktop OS

  • Linux Mint

Additional context
Edit: on another look, it seems to only apply tags to selected images that already have tags, other than the "next" file.

Errors in the debug console:

File watcher error
476.renderer.bundle.js:1 Error fired in watcher /media/max/photoes Error: ENOSPC: System limit for number of file watchers reached, watch '/media/max/photoes/specific_file.jpg'
at __node_internal_captureLargerStackTrace (node:internal/errors:464:5)
at __node_internal_uvException (node:internal/errors:521:10)
at FSWatcher. (node:internal/fs/watchers:244:19)
at Object.watch (node:fs:2247:34)
at I (352.renderer.bundle.js:2:27720)
at 352.renderer.bundle.js:2:28984
at t.exports._watchWithNodeFs (352.renderer.bundle.js:2:29453)
at t.exports._handleFile (352.renderer.bundle.js:2:30128)
at t.exports._addToNodeFs (352.renderer.bundle.js:2:33170)

This error seems new, it wasn't there until I tried to drag over the tags again:

Uncaught Error: Invalid Database State: Cannot have less than 0 untagged files.
at Xc.decrementNumUntaggedFiles (renderer.bundle.js:2:518192)
at Fe (renderer.bundle.js:2:299675)
at Xc.decrementNumUntaggedFiles (renderer.bundle.js:2:299216)
at Vl.addTag (renderer.bundle.js:2:494036)
at Fe (renderer.bundle.js:2:299675)
at Vl.addTag (renderer.bundle.js:2:299216)
at renderer.bundle.js:2:843756
at Fe (renderer.bundle.js:2:299675)
at (renderer.bundle.js:2:299216)
at jE (renderer.bundle.js:2:795726)

@RvanderLaan
Copy link
Collaborator

sorry, I can't reproduce this, it works as expected for me 😕

Feature request: It would be great (if there is a file limit) to toggle on and off the added Locations

When dealing with large amounts of files, applying search filters would act the same as "disabling locations" I think. We have thought about adding a "manual scan mode" mode that skips automatically checking for files at startup and the watching of files at runtime, in favor of a "Scan for new images" button somewhere. That's still on the to-do list. If you have more ideas it'd be better to open a thread on the discussions page 😃

@RvanderLaan RvanderLaan closed this as not planned Won't fix, can't repro, duplicate, stale Jul 31, 2022
@mrtripie
Copy link

I'm also experiencing this bug, on Windows 10 with v1.0.0-rc8.1, so I'd like if this can be reopened.
For me, sometimes it applies to the entire selection (maybe 50ish% of the time), sometimes it applies to multiple, but stops part way through (maybe 15%), and sometimes it only works on 1 (maybe 35%). After not successfully doing all of them, it so far has always done 1 at a time for the rest of the selection for additional drags.

I haven't noticed a pattern for when it works properly and when it doesn't yet, I'll add a comment about it if I do.

@RvanderLaan RvanderLaan reopened this Sep 29, 2022
@RvanderLaan
Copy link
Collaborator

Thanks for the report @mrtripie - we'll have another look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants