Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some search queries need different functions or methods #93

Open
schroef opened this issue Oct 5, 2019 · 4 comments
Open

Some search queries need different functions or methods #93

schroef opened this issue Oct 5, 2019 · 4 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@schroef
Copy link
Contributor

schroef commented Oct 5, 2019

I see that when using date as search query it has wrong function method. Should date show something before and after?

I think current ones are a bit confusing in this context. But i just noticed Adobe Bridge, for instance, uses this same principle. Should we keep this method or think of more meaning methods?
Screen Shot 2019-10-05 at 12 12 00

@schroef
Copy link
Contributor Author

schroef commented Oct 5, 2019

I guess we could perhaps use before for parts like smaller and after for greater. More for dummies perhaps :)

@RvanderLaan
Copy link
Collaborator

Yeah, that would be a nice touch, we can just change the labels. Dates are essentially just numbers for a computer so I used the same operators as for numbers

@schroef
Copy link
Contributor Author

schroef commented Oct 11, 2019

I think it would more sense and its more meanful in this context. First i had also issue with the date and understanding how it works. Some how i could find a specific image from a specific date. I did notice it was MM/DD/YYYY, but somehow it didnt show. After lots of trying i did get it to show. Ill check it again and see if it happens again.

@hummingly hummingly added enhancement New feature or request question Further information is requested labels Oct 12, 2019
@hummingly hummingly mentioned this issue Nov 9, 2019
11 tasks
@schroef
Copy link
Contributor Author

schroef commented Nov 16, 2019

I see this is closed and it still shows "Smaller than" or "Smaller than or Equals", Is this because other why you would need to add same function for this. Cant those fields have the same function yet give different name. I mean ther function basically check what the dropdown field is right. Cant that be referenced by a number. So first is 0 and then each other item adds a number. That way the naming can be different but the function in the backend is still the same.

@RvanderLaan RvanderLaan reopened this Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants