Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute path for migration directory is no longer working #403

Closed
blinktag opened this issue Feb 27, 2023 · 1 comment · Fixed by #406
Closed

Absolute path for migration directory is no longer working #403

blinktag opened this issue Feb 27, 2023 · 1 comment · Fixed by #406
Labels
bug

Comments

@blinktag
Copy link

v2.0.0 broke the ability to specify an absolute path for the migrations directory.

The culprit is likely https://github.com/amacneil/dbmate/pull/388/files#diff-85e7f15f76b0a01f7ef13c1a5e83e93ba61401694dc5118dba4180cc8f4d0a59R73 which will cause any path to be prefixed with the argument passed to DirFS()

  • Version: v2.0.0
  • Database: postgres
  • Operating System: alpine

Steps To Reproduce

The following command works correctly with v1.16.2:

$ dbmate -d /migrations migrate

Upgrading to v2.0.0 causes the following error:

Error: could not find migrations directory `/migrations`

Expected Behavior

Absolute paths should work as with previous versions
@blinktag blinktag added the bug label Feb 27, 2023
@amacneil
Copy link
Owner

Derp

@amacneil amacneil mentioned this issue Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix absolute migration directory support amacneil/dbmate
2 participants
@amacneil @blinktag