IonReader.bigIntValue() does not always return JSBI values when reading Ion binary

[YourFin]

In the process of testing my own code, I noticed that IonReader.bigIntValue() was sometimes returning number values, contrary to its contract of only returning JSBI instances or null. Further testing revealed that this only occurred when reading binary data. A minimal failing test case can be found in my fork of this repository here: YourFin@03a85a3

Some spelunking revealed that this is likely a regression introduced by 3554f29, as following the call stack down reveals that .bigIntValue() returns the any-typed _curr value on the underlying ParserBinaryRaw. Prior to 3554f29, when _curr was updated by _readIntegerMagnitude (via IonParserBinaryRaw.bigIntValue -> IonParserBinaryRaw.load_value) it could only be set to JSBI values, but following the commit it could be set to JSBI or number values.

I have what appears to be a fix for this issue committed to my fork of this repository; let me know (slack nuckolp@) if you'd like me to cut that as a pr.

[popematt]

Hi Patrick, thanks for letting us know about this problem. We would gladly accept a PR to fix it.

[YourFin]

Closing this issue as the fix was merged