Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Amp story shopping] Currency i18n #37246

Closed
processprocess opened this issue Dec 20, 2021 · 1 comment
Closed

[Amp story shopping] Currency i18n #37246

processprocess opened this issue Dec 20, 2021 · 1 comment
Assignees
@jshamble
Labels
P1: High Priority Type: Feature Request WG: stories

Comments

@processprocess
Copy link
Contributor

processprocess commented Dec 20, 2021 •
edited
Loading

Description

Use Intl.NumberFormat to enable language-sensitive number formatting.

Locale will need to be retrieved from the localization service.
This may need to be a new method in the service.

A product-price-currency entry will need to be specified in the config to display the correct currency symbol:

product-price: 100,
product-price-currency: ‘USD’

Since the currency symbol's position is dynamic it will need to be the same size as the number.
This was referenced Dec 20, 2021
Closed
Closed
Merged
@jshamble jshamble mentioned this issue Dec 21, 2021
Merged
@processprocess
Copy link
Contributor Author

Duplicate of #37126

@processprocess processprocess marked this as a duplicate of #37126 Dec 22, 2021
@mszylkowski mszylkowski mentioned this issue Jan 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jshamble jshamble

Labels
P1: High Priority Type: Feature Request WG: stories
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@processprocess @jshamble