From a18ac330bb5c4ebce2a281ce9ee6b6f42234ad1a Mon Sep 17 00:00:00 2001 From: Christoph Brand Date: Sun, 2 May 2021 09:46:51 +0200 Subject: [PATCH] feature(controller): allow autoscaler to scale down to 0 (#447) --- controllers/horizontalrunnerautoscaler_controller.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/controllers/horizontalrunnerautoscaler_controller.go b/controllers/horizontalrunnerautoscaler_controller.go index e2c2f54835..de6392b950 100644 --- a/controllers/horizontalrunnerautoscaler_controller.go +++ b/controllers/horizontalrunnerautoscaler_controller.go @@ -19,9 +19,10 @@ package controllers import ( "context" "fmt" - corev1 "k8s.io/api/core/v1" "time" + corev1 "k8s.io/api/core/v1" + "github.com/summerwind/actions-runner-controller/github" "k8s.io/apimachinery/pkg/types" @@ -186,7 +187,7 @@ func (r *HorizontalRunnerAutoscalerReconciler) SetupWithManager(mgr ctrl.Manager func (r *HorizontalRunnerAutoscalerReconciler) computeReplicasWithCache(log logr.Logger, now time.Time, rd v1alpha1.RunnerDeployment, hra v1alpha1.HorizontalRunnerAutoscaler) (int, int, *int, error) { minReplicas := defaultReplicas - if hra.Spec.MinReplicas != nil && *hra.Spec.MinReplicas > 0 { + if hra.Spec.MinReplicas != nil && *hra.Spec.MinReplicas >= 0 { minReplicas = *hra.Spec.MinReplicas }