-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--all-regions-with-lang ignoring parent-clone data #14
Comments
Note: JPN was not included on the original priority list which is expected to work. I can test with JPN also specified to see if it makes a difference and helps find the root cause of this issue. |
Could you post the specific DAT you used? That will help a lot. Also, thanks for the detailed bug report :) |
Huh, weird. I get the ones below:
Could you download the latest version (1.9.0) and try it to see how it goes? It's also going to use a much more accurate way of detecting the ROMs, though it will take a bit longer to process (but you can use the old way by adding |
Thanks for looking at this so quickly! I was planning to do a brand new filtering pass on my datable consoles, so I'm happy to try the latest version. Let me see if I can attach or paste the dat I used. If there are any issues, I'll put it up for download somewhere. |
OK, dat won't attach as the maximum comment is 64KB and the file is over 1MB. :) You can download it here: https://salumba.com/SNES.dat |
Yeah, I still get the same ROMs with your dat. Let me know if it works. |
I just downloaded a few minutes ago - how can I check the version? |
:-) |
If the version is >1.9.0, that is. Because I just introduced that |
OK, because I had already tried that. :) I was worried I didn't move the files over to my server. |
Seems to work as expected now and omits the Japanese clones I noticed earlier. |
Ok, I'm closing this then 👍 |
I'm using a version downloaded sometime last month - this might be fixed in the new version, I'll have to check later.
Issue:
When using the --all-regions-with-lang option the tool is allowing clones of an already accepted file to pass.
Example/Procedure to Duplicate Issue
Using SNES parent-clone DAT from DAT-O-Matic
Commandline arguments:
python3 generate.py -r USA,EUR -l en -e zip --all-regions-with-lang --prefer-parents --no-bios --no-program --no-enhancement-chip --no-beta --no-demo --no-sample --no-promo -d "SNES.dat" -i ../PATHIN -o ../PATHOUT
What I expect to happen
Files are grabbed in priority USA and then Europe and must have English Language - no clones. Files that are not included by this priority (from other regions) but have English language, should also be included.
"Not included" must account for being a clone of an already included title.
What is actually happening
Clones of titles already selected in the original priority are also included
Specific File Results
I get both Hebereke's Popoon from Europe AND Hebereke no Popoon from Japan. (And others like this)
The text was updated successfully, but these errors were encountered: