Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROMs with no language specified are always skipped #22

Closed
CebolaBros64 opened this issue Apr 23, 2020 · 4 comments
Closed

ROMs with no language specified are always skipped #22

CebolaBros64 opened this issue Apr 23, 2020 · 4 comments

Comments

@CebolaBros64
Copy link

ROMs with no language specified in filename are skipped regardless of the inclusion of the -l argument
Take for example, the complete Family Disk System romset. Using the following arguments:

python generate.py -r "JP" -l "en, jp" --all-regions-with-lang -d "@ dats/Nintendo - Family 
Computer Disk System (FDS) (Parent-Clone) (Parent-Clone) (20200310-115017).dat" -i "@ 
roms/Nintendo - Family Computer Disk System (FDS) (20200310-115017)" --no-all --no-unlicensed `
-o "! output/fdsc"

I only got the following ROMs as output:

Clu Clu Land (Japan) (En) (Disk Writer) [b].zip
Pro Wres (Japan) (En).zip
Vs. Excitebike (Japan) (En).zip

Omitting the -l argument outputs no ROMs.

@andrebrait
Copy link
Owner

Hm, weird. It shouldn't be this way. I'll look into it

@andrebrait
Copy link
Owner

andrebrait commented Apr 23, 2020

Well, actually, what's happening here is that:

  1. The correct region for Japan is JPN, not JP
  2. The list of languages does not handle spaces, so the languages you're providing are actually en and _jp, with a space in front of it (which I represented here with an underscore)

Yes, I should be parsing that better :-(

@andrebrait
Copy link
Owner

@CebolaBros64 did you get it to work after all?

@CebolaBros64
Copy link
Author

Yes, actually! Sorry for not answering beforehand. Changing the region from JP to JPN was enough to make it work here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants