Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Aftermarket ROMS #38

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Add support for Aftermarket ROMS #38

merged 1 commit into from
Oct 4, 2022

Conversation

cscribn
Copy link
Contributor

@cscribn cscribn commented Oct 4, 2022

This PR adds support for Aftermarket ROMS. It is similar in functionality to the way Pirate ROMS are handled. This fixes #37.

andrebrait
andrebrait approved these changes Oct 4, 2022
View reviewed changes
Copy link
Owner

@andrebrait andrebrait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks. LGTM.

@andrebrait andrebrait merged commit 9e972ba into andrebrait:master Oct 4, 2022
@westoncampbell
Copy link

Awesome! If you wanted to add one more, (Homebrew) is not always paired with (Aftermarket), so an extra option for "(Homebrew)" would be excellent!

For example, on Nintendo Game Boy, there is "Bung's Math Test (World) (Homebrew)".
It's identified as "Homebrew" but not "Aftermarket".

@cscribn cscribn deleted the aftermarket-support branch October 4, 2022 20:07
@andrebrait
Copy link
Owner

@westoncampbell done in #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrebrait andrebrait andrebrait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aftermarket Homebrew
3 participants
@cscribn @westoncampbell @andrebrait