fix(tabs): adding bootstrap 4 specific class

- Add `nav-link` class for Bootstrap 4 Closes #5488
angular-ui · Feb 16, 2016 · 3814fe3 · 3814fe3
1 parent 979fe0b
commit 3814fe3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/tabs/test/tabs.spec.js b/src/tabs/test/tabs.spec.js
@@ -56,6 +56,9 @@ describe('tabs', function() {
     it('should pass class and other attributes on to tab template', function() {
       expect(elm).toHaveClass('hello');
       expect(elm.attr('data-pizza')).toBe('pepperoni');
+      //Ensure that we have bootstrap 4 link class so things are future proofed.
+      var link = $(elm.find('a')[0]);
+      expect(link).toHaveClass('nav-link');
     });
 
     it('should create clickable titles', function() {

diff --git a/template/tabs/tab.html b/template/tabs/tab.html
@@ -1,3 +1,3 @@
-<li ng-class="{active: active, disabled: disabled}" class="uib-tab">
-  <a href ng-click="select()" uib-tab-heading-transclude>{{heading}}</a>
+<li ng-class="{active: active, disabled: disabled}" class="uib-tab nav-item">
+  <a href ng-click="select()" class="nav-link" uib-tab-heading-transclude>{{heading}}</a>
 </li>