This repository has been archived by the owner on May 29, 2019. It is now read-only.
pr3429 - Allow for custom user modal sizes #3431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed restriction to Bootstrap-native `modal-sm` and `modal-lg` size classes.
|
@RevanProdigalKnight , your committer email is set to a domain of |
| @@ -1,3 +1,3 @@ | |||
| <div modal-render="{{$isRendered}}" tabindex="-1" role="dialog" class="modal fade" ng-class="{in: animate}" ng-style="{'z-index': 1050 + index*10, display: 'block'}" ng-click="close($event)"> | |||
| <div class="modal-dialog" ng-class="{'modal-sm': size == 'sm', 'modal-lg': size == 'lg'}"><div class="modal-content" modal-transclude></div></div> | |||
| <div class="modal-dialog" ng-class="size ? 'modal-' + size"><div class="modal-content" modal-transclude></div></div> | |||
There was a problem hiding this comment.
Whoops, should be fixed now. You'd think after writing it right in the issue conversation I wouldn't make that sort of mistake...
|
No, I did not intend that. I'm not entirely sure how to change that. |
|
See https://help.github.com/articles/setting-your-email-in-git/ . You can then force push to update this PR's branch and it'll have your correct email. |
added 2 commits
March 24, 2015 13:49
Having to put in an unnecessary space that I'll then remove in order to get this to allow me to push...
removing the unnecessary space from the push force
|
Thank you! Merged and added a test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed restriction to Bootstrap-native
modal-smandmodal-lgsize classes.This change should not require any documentation changes