This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(buttons): double toggle on spacebar #4630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foxandxss
force-pushed
the
fix/buttonsaccessibilty
branch
from
5d830fe
to
57f2a39
Compare
Foxandxss
force-pushed
the
fix/buttonsaccessibilty
branch
from
57f2a39
to
732b4b6
Compare
Foxandxss
changed the title
|
LGTM Only thing I might suggest is maybe update the docs on advice for accessibility, but I'm fine with this being merged as in. |
|
What you mean with "on advice for accessibility"? |
|
Nesting an input tag so the input handles all of the accessibility requirements. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a revert of bdfb289.
A spacebar click is treated as a normal click event so it will trigger the toggle twice.
I don't think there is a proper way of testing this.
Plunker
Fixes #4474