This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(dateparser): change template literal from ' to ` #4938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleycho
force-pushed
the
feat/dateparser-backtick
branch
from
2cbdbd4
to
35e8296
Compare
- Changes from ' to ` for template literals - Adds documentation about template literals BREAKING CHANGE: This changes template literals from the single quote `'` to the backtick character `` ` `` for more natural usage with certain strings such as `o'clock`.
wesleycho
force-pushed
the
feat/dateparser-backtick
branch
from
35e8296
to
7ae4f4f
Compare
| @@ -140,3 +140,5 @@ Certain format codes support i18n. Check this [guide](https://docs.angularjs.org | |||
| \* The ones marked with `Leading 0`, needs a leading 0 for values less than 10. Exception being milliseconds which needs it for values under 100. | |||
|
|
|||
| \** It also supports `fullDate|longDate|medium|mediumDate|mediumTime|short|shortDate|shortTime` as the format for parsing. | |||
|
|
|||
| \*** It supports template literals as a string between the backtick `\`` character, i.e. `\`The Date is\` MM/DD/YYYY`. If one wants the literal backtick character, one must use `\`\`\`\``. | |||
There was a problem hiding this comment.
I don't understand the last part, it ends like ````` or something like that.
There was a problem hiding this comment.
It should be 4 backticks
There was a problem hiding this comment.
I added a random bunch in there. But I don't understand why you need 4 to put one literal.
There was a problem hiding this comment.
It has to do with the implementation - probably could use some investigation here as to what is going on, but I am just documenting it.
|
Good for me then. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This changes template literals from the single quote
'to the backtick character ``` for more natural usage with certainstrings such as
o'clock.This supercedes #4936 and addresses #4880.