This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(modal): stop IE throwing exception on focus #5097
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check if the element the model is appended to supports focus before actually calling focus.
| @@ -309,7 +309,9 @@ angular.module('ui.bootstrap.modal', ['ui.bootstrap.stackedMap']) | |||
| if (elementToReceiveFocus && elementToReceiveFocus.focus) { | |||
| elementToReceiveFocus.focus(); | |||
| } else { | |||
| appendToElement.focus(); | |||
| if(appendToElement.focus) { | |||
There was a problem hiding this comment.
This is probably better put on the else, i.e.
else if (appendToElement.focus) {
appendToElement.focus();
}There was a problem hiding this comment.
ah yes, good point indeed. completely overlooked that after console.log debugging i guess
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check if the element the model is appended to supports focus before actually calling focus to stop IE from causing exceptions and breaking the angular app
fixes #5096