This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(timepicker): Don't allow mixture of numbers and letters. #5201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,14 +51,14 @@ angular.module('ui.bootstrap.timepicker', []) | |||
| var hourStep = timepickerConfig.hourStep; | |||
| if ($attrs.hourStep) { | |||
| $scope.$parent.$watch($parse($attrs.hourStep), function(value) { | |||
| hourStep = parseInt(value, 10); | |||
There was a problem hiding this comment.
I think +value would be better if parseInt is not sufficient to ward off this issue.
|
Linking a thorough list of different number parsers for reference. IMO the unary operator is the best choice given it behaves identically to the |
|
Sounds good, will change to that method. |
|
@wesleycho, should be all set. Updated plunker with new code. |
| @@ -51,14 +51,14 @@ angular.module('ui.bootstrap.timepicker', []) | |||
| var hourStep = timepickerConfig.hourStep; | |||
| if ($attrs.hourStep) { | |||
| $scope.$parent.$watch($parse($attrs.hourStep), function(value) { | |||
| hourStep = parseInt(value, 10); | |||
| hourStep = parseInt(+value, 10); | |||
There was a problem hiding this comment.
Oh I meant just changing it all to hourStep = +value and all the rest accordingly. No need to run parseInt after +, it's already a number at that stage.
There was a problem hiding this comment.
Doh, duh, will change.
|
Alright, third times a charm! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5085
This stack says you should use Number when you want to make sure the entire string is a number.
Plunker showing fix.