This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(modal): missing require in modal #5786
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the fact that ui.bootstrap.position is an angular module dependency but not required in modal
|
This LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to import the modal alone without position causes the error:
Error: [$injector:modulerr] Failed to instantiate module ui.bootstrap.module.modal due to:
Error: [$injector:modulerr] Failed to instantiate module ui.bootstrap.modal due to:
Error: [$injector:modulerr] Failed to instantiate module ui.bootstrap.position due to:
Error: [$injector:nomod] Module 'ui.bootstrap.position' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument.
Apologies, I'm not sure how to update tests or provide a demo for this since it's strictly a webpack build issue.
Commit message:
Fixes the fact that ui.bootstrap.position is an angular module
dependency but not required in src/modal/index.js