Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Remove Buffered Transitions array #6367

Closed
wants to merge 1 commit into from

Conversation

tariqporter
Copy link
Contributor

#5967

Creating a buffered transitions array to handle clicking too quickly is unnecessary.
The code

if (nextSlide.slide.index !== currentIndex && !$scope.$currentTransition) { goNext(nextSlide.slide, nextIndex, direction); }

Already ensures that if a transition is occurring not to process another slide transition (As the vanilla bootstrap does)

Clicking several time quickly to the right, and then clicking one time left, will still shift it right:

angular-ui carousel example

whereas this issue does not exist in vanilla bootstrap

w3schools carousel example

Removing the buffered array fixes this.

@tariqporter
Copy link
Contributor Author

Anything anyone needs from me to help expedite this being merged? Currently myself and others I have spoken to have to make these changes each time they upgrade otherwise the carousel can't be deployed.

@wesleycho wesleycho added this to the 2.5.0 milestone Jan 23, 2017
@wesleycho
Copy link
Contributor

I will merge this, but I may have to revert if it does cause regressions - in the past this was due to rapid clicks not playing well with ngAnimate, although it has been quite a while since I dealt in depth with this component.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants