Failing to find ansible-build-data fails while exiting 0

[dmsimard]

I had -e antsibull_data_reset=false when running the role but ansible-build-data had not been checked out yet so it failed with the following error:
/home/dmsimard/dev/git/ansible-community/antsibull/build/ansible-build-data/5 must be an existing directory

The role continued because antsibull exit 0 instead of 1, though.
It was recorded by ara here: https://demo.recordsansible.org/results/780862.html

[felixfontein]

When reporting xxx must be an existing directory antsibull exists with error code 2. But it depends on how it is run, apparently. When installed with pip, this works fine. But when run with poetry run, it returns 0, because the binary created by poetry calls main() from antsibull.cli.antsibull_build - which does not call sys.exit() but simply returns the value. The script created by pip calls main() as well, but explicitly runs sys.exit() on its result.

When seaching a bit, I found this: https://packaging.python.org/en/latest/specifications/entry-points/#use-for-scripts and it suggests that poetry is doing something wrong. This was actually reported in python-poetry/poetry#4453, and fixed in python-poetry/poetry#4456 Unfortunately, this fix is only contained in poetry 1.2.0b1 so far...

Anyway, this is another reason to get #417 merged ASAP and remove the role's dependency on poetry ASAP :)

[felixfontein]

This one should be effectively fixed (at least when using the role) since #420 has been merged.