Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANY/ALL convergence setting doesn't save sometimes for approval nodes #6998

Closed
jakemcdermott opened this issue May 12, 2020 · 3 comments
Closed

Comments

@jakemcdermott
Copy link
Contributor

ISSUE TYPE
  • Bug Report
STEPS TO REPRODUCE
  • Create and save workflow that looks like this:
    Screenshot from 2020-05-12 10-12-06
  • Open the workflow visualizer for the workflow, change the convergence setting of the approval node to ALL and save.
EXPECTED RESULTS
  • The new convergence setting should save and the approval node should now have an ALL tag.
  • There should be api requests in the console log showing that the updated convergence values were sent to the API by the browser.
ACTUAL RESULTS
  • The convergence setting doesn't save
  • No requests in the browser console logs showing the updated convergence setting.
ADDITIONAL INFORMATION

Interestingly, the topology of the workflow seems to be a factor. if you create a workflow that looks like this:
Screenshot from 2020-05-12 10-04-55
The approval node's convergence setting can be updated as expected.

@kdelee
Copy link
Member

kdelee commented Jul 7, 2020

@dsesami @unlikelyzero @shebangbash this one is hanging out from a while back, should be easy as we already verified it for the tower patch release

@unlikelyzero
Copy link

@kdelee i'll take non-4.0 tasks. Feel free to @ or assign me directly

@unlikelyzero
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants