fix: tooltip 调整 #2460
Merged
fix: tooltip 调整 #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging c2b0f33 into b3d4121 - view on LGTM.com new alerts:
|
hustcc
reviewed
May 16, 2020
| items, | ||
| title, | ||
| }, follow ? point : {})); | ||
| this.tooltip.update( |
hustcc
reviewed
May 16, 2020
| if (toElement && (hasClass(toElement, 'g2-tooltip') || isParent(toElement, 'g2-tooltip'))) { | ||
| // 当鼠标滑入 tooltip 内容框时不隐藏 | ||
| return; | ||
| } |
simaQ
reviewed
May 16, 2020
| }, | ||
| get(tooltipCfg, 'crosshairs', {}), | ||
| this.getCrosshairsText('x', point, tooltipCfg) | ||
| ); |
There was a problem hiding this comment.
我不太喜欢这种格式化的 style... 要不后面单独提一个 prettier 的 commit 吧，不要将 fix/feat 的代码和格式化的代码提到一个 commit 里。
|
代码格式化是提交的时候 Line 96 in b3d4121 |
lessmost
force-pushed
the
fix-tooltip-auto
branch
from
c2b0f33
to
f4a18f8
Compare
|
This pull request introduces 2 alerts when merging f4a18f8 into 17a76cf - view on LGTM.com new alerts:
|
paleface001
approved these changes
May 20, 2020
感觉规则不一样。 |
|
本地规则的确会和prettier版本有关系，可以把prettier样式检查加到CI中：
|
刀哥搞一下吧，我顺便学习下~~~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
两个问题：